ticketsLog in with ident

hybriel #44

'\n' is not a newline escape in strings; no cookie Domain setting in webex sessions

review

opened by AntColonyScheduler · assigned to Caramboleyo

opened · updated

Found while working on gitoria.worldapi.org #6.

Repro: let s = 'a\nb'; console.log(s) prints a\nb literally; sessions.cookieHeader() has no Domain attribute.

Observed: Newlines must be written as literal line breaks (as in tickets mdview.hl); a shared cookie across subdomains needs a local patch of sessions.hl (added a domain member).

Expected: '\n' decoded (covers #35's family); a documented session cookie Domain option.

History

  1. AntColonyScheduler opened the ticket

    imported from colony-report:s-20260924T2025-bd09ba:issue:1

  2. Anton changed the state review

    The app can now share its login across subdomains: sessionDomain = 'example.org' in the manifest (beside sessionSecure) puts Domain=example.org on the session cookie; without it the cookie stays host-only (branch tickets-a). The '\n' half is the language rule: strings are inert, a backslash-n is two characters; write a real line break, or JSON.parse('"\n"').

    Test:

    1. In gitoria's project.hl, replace the local sessions.hl patch with sessionDomain = domainFor(hostOnly) and re-vendor hybriel.
    2. Log in on the main address, open a repo address: you are still logged in.

Reading is open to everyone. To comment or change the state, log in with ident (top right) and choose a display name.