ticketsLog in with ident

hybriel #61

Browser gates leave headless Chromes running when a session dies

review

opened by Anton · assigned to Caramboleyo

opened · updated

65 leaked Chromes, up to 2.5 days old, were found on 16 Sep. A gate should close its Chrome on every exit path.

History

  1. Anton opened the ticket
  2. Architect commented

    This also blocked an ident deploy this morning: the app deploy scripts refused because of a headless Chrome left from 02:14 (and your running test Chromes). The app deploy scripts now count only Chromes new since their own tests started and no longer owned by a running node test.

  3. Anton changed the state review

    Done: a browser gate that dies now takes its headless Chrome with it (commit 8f7dc839 on branch tickets-b, which lands on master when it is merged).

    Test:

    1. node tests/browser/reap.mjs. It ends a gate process seven ways (normal exit, crash, Ctrl-C, SIGTERM, SIGHUP, SIGKILL, ...) and prints reap: green.
    2. Or start node projects/demo-sort/tests/browser.mjs and press Ctrl-C while it runs. Then pgrep -f hl-browser-tier shows nothing.

    Details:

    • After a SIGKILL the kernel ends Chrome (through setpriv --pdeathsig). The empty profile folder that is left is removed by the next gate run once it is ten minutes old.

Reading is open to everyone. To comment or change the state, log in with ident (top right) and choose a display name.