hybriel
Rename hl:webex back to hl:web
opened by Anton · assigned to Caramboleyo
opened · updated
Evaluate the implications first - demos, new live projects from worldapi - then do it
History
Anton opened the ticket Architect commented Heads-up from the apps side: tickets, ident and gitoria import hl:webex and carry local patches in their vendored webex (inline-script escaping, var() tokens from imported files, gitoria: session cookie Domain). A rename means changing their imports and re-vendoring together — please say in this ticket when it lands on master.
Architect commented Checked on master (edf27bc1, 08:18): the rename has not landed. plugins/web is still the older hl:web, plugins/webex is the compiled framework the apps use, and both plugin.json say "hl:web". The creator believed webex was gone hours ago. The apps stay on hl:webex until this lands.
Anton commented Evaluation: the rename is safe to do now; nothing live breaks, and the three apps switch when they next re-vendor.
Details:
- In hybriel: hl:webex becomes hl:web, the old walking hl:web is deleted. The demos that imported the old hl:web (framework, demo-sort, demo-nested, demo-blog) keep their imports and get the compiled framework; demo-social-network changes two imports. Same routes and same page HTML, so no app code changes.
- tickets, ident, gitoria carry their own plugins/webex (with the local patches) and import 'hl:webex', so they keep running unchanged. When they re-vendor: take plugins/web from master, delete plugins/web + plugins/webex, and change every 'hl:webex' to 'hl:web' in every .hl file (project.hl, styles.hl, shared/tokens.hl) in one go - a half switch is refused at boot. worldapi-tokens/tokens.hl needs the same one-line change. Their vendored copies are behind master (they miss the #32 if-branch fix), and the var() token patch (#39) and inline-script escaping are already on master.
- routger imports hl:web and gets the new framework, but it does not boot today either, on the old one or the new one: project.hl:16
String defaultParent = Mainis refused by the language. The rename does not change that.
Anton changed the state review Done: hl:webex is now hl:web, and the old hl:web is gone (commit 38b6b56f on branch tickets-b; it lands on master with the merge).
Test:
- On master after the merge:
ls pluginsshowsweband nowebex. cd projects/framework && hybriel server.hl, open http://localhost:44333/ - the page works, and its source loads/__hl/web/client.js.cd projects/demo-social-network && hybriel project.hl- it starts and serves as before.
Details:
- tickets, ident, gitoria: keep running on their vendored plugins/webex. To switch: copy plugins/web from master, delete their plugins/webex, change every 'hl:webex' to 'hl:web' in all .hl files at once (worldapi-tokens/tokens.hl too).
- Also fixed on the way: in a --native binary the file watcher of the new framework watched a wrong path, so a save never reloaded the tab.
- On master after the merge:
Reading is open to everyone. To comment or change the state, log in with ident (top right) and choose a display name.