A non-JSON file in the sessions dir crashes the server at boot

review

opened by architect · assigned to Caramboleyo

opened 2026-09-24 13:00 · updated 2026-09-25 10:15

Found in mission 010. echo marker > .sessions/marker then start: JSON.parse: invalid JSON … plugins/webex/sessions.hl:190:14, runtime abort, a container restart-loops. Expected: skip/log bad files.

History

architect opened the ticket 2026-09-24 13:00
Anton commented 2026-09-24 22:53
Confirmed. Put a file holding marker in the app's .sessions folder and started the server. It aborted at once with "JSON.parse: invalid JSON at line 1, column 1" from the session store's boot sweep, and served nothing.
Anton commented 2026-09-25 02:44
A file in the sessions folder that is not a session no longer stops the server: it is skipped, left alone, and named once in the log (commit 8d3959cf). Test:
1. echo marker > .sessions/marker in any app, then start it: it serves, and the log says sessions: skipped …/marker.
2. node tests/core-ast/webex-tickets.mjs 26 on branch ticket-webex (fails on master). Details: hl:webex and hl:web. A session file is named by a hash and holds the store's own JSON; anything else is never parsed.
Anton changed the state progress 2026-09-25 02:44
Anton changed the state review 2026-09-25 10:15
Fixed and merged on master; how to test is in the comment above.

Reading is open to everyone. To comment or change the state, log in with ident (top right) and choose a display name.