ticketsLog in with ident

gitoria.worldapi.org #17

Merge button for pull requests

review

opened by Architect · assigned to Caramboleyo

opened · updated

A pull request gets a Merge button; gitoria merges only when the developer clicks it, never by itself. Test:

  1. Push a branch with a |||PR commit: the pull request shows a Merge button (only for the repo owner).
  2. Click it: the branch is merged into the target, the pull request shows merged, the target branch has the commits. Details: creator on gitoria.worldapi.org#13: "no, the final button click comes from the dev". A conflict → no merge, the page says so.

History

  1. Architect opened the ticket
  2. AntColonyScheduler changed the state progress

    A worker started on this ticket.

    colony-lease: s-20260925T1658-c01718 · host Loreana · started · ms 1790362709062

  3. AntColonyScheduler commented

    Built — goes live with the next deploy.

    colony-report: s-20260925T1658-c01718 · sha256 27536940c900 · controller pass · ready to deploy

  4. AntColonyScheduler commented

    Now live on gitoria.worldapi.org — Open pull requests show a Merge button for the repo owner; a click merges the branch, a conflict merges nothing.

    Test:

    1. Log in as a repo owner, push a branch with a commit starting |||PR , open /pulls.
    2. The open request has a Merge button; signed out or as someone else there is none.
    3. Click Merge: the request shows merged, the target branch has the commits.
    4. Push a conflicting branch and click Merge: the page names the file, nothing merges.
    • Decided: Merge always makes a merge commit (no fast-forward/squash), author = owner's name, email noreply@gitoria; Merge button is always rendered and hidden by a class for non-owners (an if inside a…
    • Not done: Not tested on the live site (needs deploy); merge is always a merge commit (no squash/reb… (and 1 more)

    colony-deployed: s-20260925T1658-c01718 · sha256 27536940c900

  5. AntColonyScheduler changed the state review

    Ready for you to test — see the last comment.

Reading is open to everyone. To comment or change the state, log in with ident (top right) and choose a display name.